Make sure no SayIt Speaker is associated with a blacklisted PopIt IDs #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if a PopIt ID was blacklisted, a speech might still end up being associated with that person because there would still be a Speaker object with the exact name that's being resolved which has its person attribute set to a Person with the blacklisted PopIt ID. This commit makes sure that any Speaker with a person attribute with a blacklisted PopIt ID has that person attribute set to None when the ImportJson object is initialized. Fixes mysociety/pombola#1740
mhl
force-pushed
the
fix-person-blacklisting
branch
from
cf947a1
to
fe4c8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if a PopIt ID was blacklisted, a speech might still end up
being associated with that person because there would still be a
Speaker object with the exact name that's being resolved which
has its person attribute set to a Person with the blacklisted
PopIt ID.
This commit makes sure that any Speaker with a person attribute
with a blacklisted PopIt ID has that person attribute set to None
when the ImportJson object is initialized.
Fixes #1740